feat(graph): add full_verify preset — one-command build->spec->test->review - #130
Merged
Conversation
…iew (#120) The chaining mechanism already existed generically via from_spec (any comma-separated agent list, e.g. --pipeline=build,spec,test,review already worked) — what was missing was a dedicated, memorable preset for exactly this sequence, matching #120's own title. The closest existing preset, impl_then_spec_then_test, runs test and review in PARALLEL after spec, so review sees the same untested output test is concurrently checking rather than reviewing what test verified. Adds full_verify() = build → spec → test → review as a strict sequence, wired into preset()/preset_names()/preset_shape()/is_preset(). Extended spec_matches_preset() to assert build,spec,test,review and full_verify produce identical shapes, matching the existing discipline for the other three presets. Live-verified end to end (not just type-checked) with run_graph_persistent against a real task: spec genuinely located and read the file build wrote (via glob/read tool calls), wrote and proved 4 real spec properties via lex_spec_check (self-correcting two real syntax mistakes along the way), test recognized the existing examples{} coverage instead of duplicating it, and review used effects_of/ attestation_query/lex_check for a real, evidence-based verdict — not four independent runs that happened to share a task description. Inspected all four persistent trails (.lex/sessions/{impl,spec,test, review}.db) afterward: each has distinct, mode-appropriate event counts and kinds — spec's trail alone has 4 real verified.spec_check attestations (matching the 4 proved properties) and 2 cap.failed events (matching the two self-corrected mistakes); test and review each have their own verified.type_check. Every stage's activity is attributable to that stage specifically. Fixes #120 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #120
Test plan
🤖 Generated with Claude Code