Skip to content

DRY: deploy_one_click_app uses create_and_update_app #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IamJeffG wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DRY: deploy_one_click_app uses create_and_update_app #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cd4a33
Use create_and_update_app in deploy_one_click_app
IamJeffG Jul 21, 2026
780e465
Patch version bump: 0.1.25
IamJeffG Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
History
=======

0.1.25 (2026-07-21)
-------------------

* Use `create_and_update_app` from `deploy_one_click_app`.
This attempts to avoid a rare race condition when `deploy_one_click_app()` calls
`update_app` too quickly after `create_app`: `create_and_update_app` includes some sleeps.

0.1.24 (2024-12-16)
-------------------

Expand Down
2 changes: 1 addition & 1 deletion caprover_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

__author__ = """Akash Agarwal"""
__email__ = 'agwl.akash@gmail.com'
__version__ = '0.1.24'
__version__ = '0.1.25'
21 changes: 7 additions & 14 deletions caprover_api/caprover_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,15 +419,15 @@ def deploy_one_click_app(
service_override_dict, default_style="|"
)

# create app
self.create_app(
app_name=service_name,
has_persistent_data=has_persistent_data
)
image_name = service_data.get("image")
docker_file_lines = caprover_extras.get("dockerfileLines")

# update app
self.update_app(
# create + update + deploy in one call
self.create_and_update_app(
app_name=service_name,
has_persistent_data=has_persistent_data,
image_name=image_name,
docker_file_lines=docker_file_lines,
instance_count=1,
persistent_directories=persistent_directories,
environment_variables=environment_variables,
Expand All @@ -436,13 +436,6 @@ def deploy_one_click_app(
serviceUpdateOverride=service_update_override,
tags=tags,
)
image_name = service_data.get("image")
docker_file_lines = caprover_extras.get("dockerfileLines")
self.deploy_app(
service_name,
image_name=image_name,
docker_file_lines=docker_file_lines
)
apps_deployed.append(service_name)
return {
"status": CaproverAPI.Status.STATUS_OK,
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.1.24
current_version = 0.1.25
commit = True
tag = True

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
test_suite='tests',
tests_require=test_requirements,
url='https://github.com/ak4zh/caprover-api',
version='0.1.24',
version='0.1.25',
zip_safe=False,
)