DRY: deploy_one_click_app uses create_and_update_app#25
Open
IamJeffG wants to merge 2 commits into
Open
Conversation
Replaces the separate create_app/update_app/deploy_app calls with a single create_and_update_app call, making the code more DRY.
IamJeffG
force-pushed
the
deploy_one_click_app-uses-create_and_update
branch
from
July 21, 2026 15:23
32fad15 to
780e465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the separate
create_app/update_app/deploy_appcalls with a singlecreate_and_update_appcall, making the code more DRY.No API change or behavior change... other than that we're hoping for a side-effect from
create_and_update_app's 0.10s sleeps (which had not been present indeploy_one_click_app):We intermittently hit CapRover's "No NodeId was found" error (see caprover/caprover#930) between
create_appand the firstupdate_app, specifically when the app uses persistent data. My read fromServiceManager.updateAppDefinitionis:create_appregisters a new app, CapRover appears to spin up a placeholder service for it.create_app -> _wait_until_app_readypolls onisAppBuildingbut not on Swarm's task scheduling, so it can return before the new task has actually been assigned a NodeID.The 0.10s sleep isn't a guaranteed fix for this gap, but it happens to sit in the right place, so worth a try. Even if it doesn't fix "No NodeId was found", this PR is still a simple DRY improvement.