test(vllm): restore decode migration coverage - #13693
Open
alec-flowers wants to merge 1 commit into
Open
Conversation
alec-flowers
force-pushed
the
codex/vllm-decode-migration
branch
from
August 23, 2026 17:10
3d2ed82 to
b86cabc
Compare
alec-flowers
changed the base branch from
codex/vllm-agg-migration
to
codex/vllm-prefill-migration
August 23, 2026 17:10
This was referenced Aug 23, 2026
Signed-off-by: Alec Flowers <aflowers@nvidia.com>
alec-flowers
force-pushed
the
codex/vllm-decode-migration
branch
from
August 24, 2026 03:18
b86cabc to
49c854b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kv_bothtransfer configuration now required by disaggregated vLLM workers.nightlyafter no-retry pre-merge CI passes.Scope reduction and traceability
The inherited covering array supplied eight rows to every migration test. Decode migration can only inject its fault after a response stream has started, so the four unary rows were not applicable and immediately self-skipped.
migration_enabled-worker_failure-chat-stream-natsmigration_disabled-graceful_shutdown-completion-stream-natsmax_seq_len_exceeded-worker_failure-completion-stream-tcpmax_seq_len_not_exceeded-graceful_shutdown-chat-stream-tcpThis changes decode collection from eight outer-skipped rows (and four additional inner skips if the outer skip was bypassed) to four named executable cases with no skip.
Live root cause
Forced execution in the exact nightly image failed before model readiness:
The test harness had not followed the current disaggregated vLLM CLI contract. Adding the canonical
NixlConnector/kv_bothconfiguration lets the test reach and validate the complete decode migration chain. The enabled chat case also exercises the historical request-ID/prefix-cache regression described by the removed skip.Validation
Exact image:
-n 4 --max-vram-gib=41: 4/4 passed first attempt, zero retries/skips, in 150.05s (2m30s); scheduler reported 3.5x versus 520s sequential and observed an 18.1/48 GiB suite peak.isort, direct single-workerblack --check,flake8,codespell,ruff, whitespace checks,py_compile, andgit diff --checkpassed.No retry-assisted result is included, and no new test was added: this restores the existing behaviorally justified end-to-end test at its smallest meaningful surface.
Stack navigation
This PR is layer 3 and targets
codex/vllm-prefill-migration. Review and merge the stack in order.