test(vllm): remove unsupported prefill migration test - #13692
Open
alec-flowers wants to merge 1 commit into
Open
test(vllm): remove unsupported prefill migration test#13692alec-flowers wants to merge 1 commit into
alec-flowers wants to merge 1 commit into
Conversation
This was referenced Aug 23, 2026
Signed-off-by: Alec Flowers <aflowers@nvidia.com>
alec-flowers
force-pushed
the
codex/vllm-prefill-migration
branch
from
August 24, 2026 03:18
6053663 to
b2b435c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support evidence and decision
This is intentionally a removal rather than an unskip:
Migrationoperator wraps the complete prefill-to-decode pipeline. On a migratable error,RetryManagerclones and reissues thePreprocessedRequestthrough that pipeline.xfailwithPrefill migration not yet supported; it was later converted to an unconditional skip. It never represented a supported regression boundary.xpasscould not distinguish full recomputation from state migration.A permanently skipped hypothetical test has no regression sensitivity and should not remain in the nightly denominator. If partial prefill-state transfer is implemented later, it needs a new test with an observable state-reuse contract.
Validation
28 tests collected20 tests collected(8 unsupported prefill nodes removed)python3 -m py_compile tests/fault_tolerance/migration/test_vllm.pygit diff --checkpytest-marker-reportreached the changed file and reportedtests/fault_tolerance/migration/test_vllm.py: 20, then failed while collecting unrelated suites because the shared test port allocator was exhaustedNo GPU run was needed: this change only deletes an unconditionally skipped test, and production-code inspection conclusively shows that its claimed state-transfer capability is absent.
Stack navigation
This PR is layer 2 and targets
codex/vllm-agg-migration. Review and merge the stack in order.