Skip to content

feat(specreview): add gap-analysis to the analysis enum#5

Merged
kreneskyp merged 1 commit into
mainfrom
feat/gap-analysis-analysis-enum
Jun 22, 2026
Merged

feat(specreview): add gap-analysis to the analysis enum#5
kreneskyp merged 1 commit into
mainfrom
feat/gap-analysis-analysis-enum

Conversation

@kreneskyp

Copy link
Copy Markdown
Contributor

What

Adds gap-analysis to the SpecReview.analysis enum:

  • spec_artifacts_process/schemas/spec-review-frontmatter.schema.json — append "gap-analysis" to properties.analysis.enum
  • spec_artifacts_process/skeletons/SpecReview.md — list it in the authoring-comment enum

Why

This is the v0.4.0 feature bump that backs the new quoin gap-analysis skill (a post-implementation verification gate). The skill emits one quire-validated SpecReview per run with analysis: gap-analysis, matching the one-analysis-per-doc model the other review lenses already use. quire validate rejects the doc today because the enum lacks the value.

Coupling

On merge + tag v0.4.0, bump the default-modules.yaml pin in agent-ix/quoin to v0.4.0 so the gap-analysis evals (EV-030..033) go green in CI. Until then they are RED-in-CI by design (same pattern as the SpecReview archetype rollout / EV-026).

Validation

make test + make lint green. End-to-end: a sample analysis: gap-analysis SpecReview validates (exit 0); a bogus value is correctly rejected against the enum now including gap-analysis.

🤖 Generated with Claude Code

Adds `gap-analysis` as a valid value for the SpecReview `analysis`
frontmatter field (schema + authoring skeleton). This is the v0.4.0
feature bump that lets the new quoin `gap-analysis` skill emit a
quire-validated SpecReview (one analysis = one doc, like the other
review lenses).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kreneskyp kreneskyp requested a review from a team as a code owner June 22, 2026 15:09
@kreneskyp kreneskyp merged commit dc555cc into main Jun 22, 2026
4 checks passed
@kreneskyp kreneskyp deleted the feat/gap-analysis-analysis-enum branch June 22, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant