feat(skills): add gap-analysis verification-gate skill + evals#14
Merged
Conversation
New `gap-analysis` skill: a post-implementation gate over one targeted plan. It verifies (1) every task is done, (2) each Test Matrix TC is backed by a real tracking tag in the tests, (3) code is fully traced to spec (flagging underspecified code), with an optional (4) semantic review of intent<->test<->code. Emits one quire-validated SpecReview (analysis: gap-analysis) to reviews/YY-MM-DD-<slug>.md with a Verdict (PASS/CONDITIONAL/FAIL) and a findings table. Evals EV-030..EV-033 cover the happy + sad branches (combined FAIL, clean not-FAIL, medium-only CONDITIONAL, optional semantic catches a hollow test) via a shared seedGapBundle fixture, plus a new `fileContains` assertion that checks the actual Verdict/findings. Requires spec-artifacts-process v0.4.0 (the gap-analysis analysis enum). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new
gap-analysisskill — a post-implementation verification gate over one targeted plan — plus an eval suite.Skill (
skills/gap-analysis/): SKILL.md + 6 step references. It checks:Taskisstatus: doneTC-xxxis backed by a real tracking tag in the testsOutput: one quire-validated
SpecReview(analysis: gap-analysis) atreviews/YY-MM-DD-<slug>.mdwith a Verdict (PASS/CONDITIONAL/FAIL) and a findings table.Evals (
evals/): EV-030..EV-033 cover happy + sad branches via a sharedseedGapBundlefixture, plus a newfileContainsassertion (evals/lib/assert.mjs) that checks the actual Verdict/findings:Validation
make testgreen (102/102);make lintclean for the changed files.Dependency
Requires
agent-ix/spec-artifacts-processv0.4.0 (thegap-analysisanalysis enum — agent-ix/spec-artifacts-process#5). The evals are RED-in-CI until v0.4.0 is tagged and thedefault-modules.yamlpin is bumped to it (same release-coupling as EV-026); proven green locally by temporarily sourcing the module from the local working tree.🤖 Generated with Claude Code