fix: harmonize French terminology and narration - #21
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fabbfc5301
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const [messageId, frenchText] of Object.entries(fr.messages)) { | ||
| const matches = frenchText.match(firstPersonPluralPast); |
There was a problem hiding this comment.
When a chapter uses first-person plural passé simple inside dialogue or a deliberately historical, legendary, or formal voice, this loop scans the entire message and fails the suite anyway. That contradicts docs/translation-fr.md:13, which explicitly permits the tense in those contexts, so a compliant future translation would be blocked unless this check distinguishes main narration or supports contextual exceptions.
AGENTS.md reference: AGENTS.md:L104-L106
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
pnpm checkpnpm testpnpm buildpnpm content:allwhen source content or content tooling changedpnpm images:check -- --book 1pnpm images:test.env*, local save exports, or local image API outputs includedNotes