fix: nested branches, session providers, and stale cwd state - #6
Merged
Conversation
Keep git-style names like feat/auth inside .memory/branches, forward session extensions except Brain into the isolated committer, and drop in-memory Brain objects when cwd moves to an uninitialized project. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/auth) while still blocking path escape (../,\,.,.., empty segments). Existing nested dirs are listed again; no rename migration.--no-extensionsplus--extensionforpi -e, settings.json, and Pi's standard extension directories), skipping this package so Brain cannot reload onto the log it is distilling.committer.extensionsstill replaces that list when set..memory/.Providers installed only as Pi packages (
pi install npm:some-provider) are still not auto-forwarded; those needcommitter.extensionsor an-e/ extensions-directory install.Test plan
pnpm run checkin.worktrees/known-limits(226 tests)memory_branchwithname: feat/auth, confirm files land under.memory/branches/feat/auth/and../escapestill failsmemory_commitwith a custom provider loaded viapi -e/~/.pi/agent/extensionsand nocommitter.extensionsin config.memory/: footer clears, previous project'slog.mdis unchangedMade with Cursor