fix: SSH/.git Brain spec exclusion and phantom nested-branch parents - #9
Merged
Conversation
Delivery-owner verification of #6 found two holes: - isBrainExtensionSpec matched only 'github.com/Whamp/pi-brain/' with a literal slash and no .git suffix, so pi-brain installed via git@github.com:Whamp/pi-brain.git (SSH) or an https URL with .git suffix would be forwarded to the committer child — re-enabling the self-reload onto log.md that --no-extensions exists to prevent. The regex now accepts ':' or '/' after github.com and an optional .git suffix; lookalike repos (pi-brain-fork) are still passed through. - branchExists() treated any directory as a branch, so the parent dir of a nested branch (e.g. 'feat' for 'feat/auth') was switchable; OTA entries would then be appended to feat/log.md in a directory that listBranches never shows. A branch now requires commits.md, the same marker collectBranchNames uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery-owner verification pass on #6 found two holes; both fixed test-first (red → green).
isBrainExtensionSpeconly matchedgithub.com/Whamp/pi-brain/(literal slash, no.git). An install viagit@github.com:Whamp/pi-brain.gitorhttps://github.com/Whamp/pi-brain.gitwould be forwarded to the committer child, re-enabling the self-append-to-log bug Committer follow-ups: subprocess isolation, SIGKILL escalation, YAML comment support #3 fixed. Regex now covers://separator and.gitsuffix;pi-brain-forklookalikes still pass through.branchExists('feat')was true when onlyfeat/authexisted (dir-without-commits.md), letting OTA writes orphan into an unlisted directory. Branches now require thecommits.mdmarker — the same criterioncollectBranchNamesuses.229 tests green,
pnpm run checkall green, aislop/slop-scan clean.