Committer follow-ups: subprocess isolation, SIGKILL escalation, YAML comment support - #3
Merged
Conversation
added 2 commits
August 17, 2026 13:46
The committer child pi now runs with --no-extensions so a trusted project cannot reload pi-brain and append to the log.md being distilled. The abort path no longer guards SIGKILL behind proc.killed (true as soon as kill() is called), so a child that ignores SIGTERM is killed after 3s instead of hanging the commit. Locks the model/thinking argv contract (config override, session inherit, fallbacks) with fake-pi spawn tests.
parseYaml now strips inline comments (unquoted ' #' only), skips comment lines anywhere in nested maps and lists, and no longer turns '# comment:' lines into bogus keys or drops a nested map separated from its key by a comment. serializeYaml quotes values containing ' #' so they round-trip. Also covers the init-script config skeleton: comment-only file parses to an empty object and re-init never overwrites a user config. Fixes a stale 'all five' mutation-checklist count.
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #2 (issue #1), from two independent reviews (GPT + Grok 4.6 cross-check).
Committer child hardening
--no-extensionson the spawned committer pi: a trusted project can no longer reload pi-brain in the child, whoseturn_endhook would append to the verylog.mdbeing distilled.proc.killedis true as soon askill()is called, so the old!proc.killedguard never fired SIGKILL — a child ignoring SIGTERM hung the commit forever (matches hang reports on memory_commit is currently hardwired to use Antigravity #1). SIGKILL now fires unconditionally after 3s.YAML comment support
#outside quotes) are stripped from scalars; quoted#preserved; serializer quotes values containing#so they round-trip.# comment:lines into bogus keys. Previouslycommitter:followed by a comment silently dropped the whole block to session defaults — including the init skeleton's own commented example.Tests (the gap both reviews flagged)
pnpm run checkgreen.