improve the Wait for Package locks#158
Open
FrankiePustorino wants to merge 1 commit into
Open
Conversation
Commit based on my comment under issue for Internet connecttion
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the WAIT_FOR_PACKAGE_LOCKS function, the hang is caused by sudo lsof — it can block indefinitely if a lock file is held by a process that itself is waiting. Also, piping through sudo tee adds another potential stall point. The fix is to:
Replace lsof with fuser (faster, purpose-built for file-use checks) with a timeout
Remove the tee pipe that's unnecessary for the logic
Add a hard timeout wrapper so the check can never hang indefinitely
Here's the fixed WAIT_FOR_PACKAGE_LOCKS function