Robust Internet check#157
Open
FrankiePustorino wants to merge 2 commits into
Open
Conversation
Three concrete changes: Improve CHECK_INTERNET — add a wget fallback if curl is absent, a DNS resolution tier between HTTP and ping, and 2 retry attempts with a brief gap before giving up Add REQUIRE_INTERNET — a wrapper that calls CHECK_INTERNET and handles the exit messaging, callable from anywhere Remove the top-level gate — put REQUIRE_INTERNET inside PREUPDATE_PREFLIGHT (all maintenance paths go through it) and inside UPGRADE_EOL_TO_NEXT (its own path); add a pre-scan before the while loop so --help and --version exit before anything network-related is even reached
Contributor
Author
There was a problem hiding this comment.
I have added also the pull request 158 in this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three concrete changes:
Improve CHECK_INTERNET — add a wget fallback if curl is absent, a DNS resolution tier between HTTP and ping, and 2 retry attempts with a brief gap before giving up
Add REQUIRE_INTERNET — a wrapper that calls CHECK_INTERNET and handles the exit messaging, callable from anywhere
Remove the top-level gate — put REQUIRE_INTERNET inside PREUPDATE_PREFLIGHT (all maintenance paths go through it) and inside UPGRADE_EOL_TO_NEXT (its own path); add a pre-scan before the while loop so --help and --version exit before anything network-related is even reached