docs: retake the home page screenshot and delete the unused asset - #282
Conversation
The docs front page showed VS Launcher: old branding in the window title and the welcome heading, a sidebar reading Versions and Changelog, and the MVL promotion that was removed from the app. It is replaced by a capture of RiftLauncher's own home page, taken from a build of dev against an empty config seeded with two sample Installations, so the shot carries no personal account or library. The old file was named after a version that no longer means anything, so the new one is riftlauncher-home.png and the caption drops the apology. vslauncher.png went too: nothing referenced it. The GitHub and VS Code screenshots on the translation page still show the old repository. Those need a browser and a signed-in account, so #269 stays open for them.
Zaldaryon
left a comment
There was a problem hiding this comment.
Approved. This test-only change correctly replaces jsdom's noisy window.scrollTo implementation in the shared renderer-dom setup. I reproduced the base and head behavior: 224 renderer-dom tests passed on both, while the base emitted three "Not implemented: Window's scrollTo() method" lines and the head emitted none. The override is scoped to jsdom and leaves production behavior unchanged.
Local verification passed: npm run typecheck; npm run lint:ci with 0 errors and 15 existing warnings; npm run format:check; npm run test:coverage with 1633 passed and 2 skipped and coverage of 92.60% statements, 89.84% branches, 92.03% functions, and 94.05% lines; and npm run build:unpack. GitHub typecheck, lint, test, SonarCloud, Ubuntu build, and Windows build passed. The macOS build is policy-skipped.
Zaldaryon
left a comment
There was a problem hiding this comment.
Follow-up approval for the current head 6f14a04. The current range replaces the old VS Launcher home screenshot with a 1280 by 720 RiftLauncher capture, updates docs/README.md to the matching path, and removes two assets that have no remaining references. I inspected the new image and found no visible account, personal path, or private workspace data. The earlier review was submitted while the PR head changed, so this approval covers the current documentation range.
Local verification passed: npx prettier --check docs/README.md; npm run typecheck; npm run lint:ci with 0 errors and 15 existing warnings; npm run format:check; npm run test:coverage with 1633 passed and 2 skipped and coverage of 92.60% statements, 89.84% branches, 92.03% functions, and 94.05% lines; and npm run build:unpack. GitHub typecheck, lint, test, SonarCloud, Ubuntu build, and Windows build passed. The macOS build is policy-skipped.
Issue #269 asked for the documentation screenshots that predate the rebrand to be retaken. One of them could be retaken here. The rest cannot, and the reason is the same for all of them: they are pictures of GitHub and of Visual Studio Code, not of this application, so taking them needs a browser and a signed-in GitHub account rather than a build.
What the docs actually reference
Every
.mdunderdocs/plus the README were walked, and every image indocs/.gitbook/assets/was opened to see what it shows rather than trusting its file name. There are eighteen assets and seventeen references. One asset,vslauncher.png, was referenced by nothing, exactly as the issue said, and is deleted. The README's images are all shields.io and SonarCloud badges, which are generated on request and cannot go stale.VSL_Main_1.3.0.pngriftlauncher-home.pngvslauncher.pngfork-EDITED.pngXurxoMF/vs-launcherrepository front page with the Fork button circled, 13 stars, 4 forksnew-fork-EDITED.pngvs-launcher-es-EScopy-clone-EDITED.pngMFXurxo/vs-launcher-es-ESwith the Code dropdown open on the clone URLpr-EDITED.pngcreate-pr-EDITED.pngXurxoMF/vs-launcher, title and description filled insync-new-changes-EDITED.pngopen-on-vscode-EDITED.pngvs-launcher-es-ES, in Galicianedit-lang-list-EDITED.pngi18n.tsopen in VS Code with eight locale files in the exploreradd-new-lang-EDITED.pnglocalesfolder in the VS Code explorer, eight filesinstall-i18n-ally-EDITED.pngtrust-authors-EDITED.pngchange-main-lang-EDITED.pngcommit-1-EDITED.pngcommit-2-EDITED.pngallow-login-EDITED.pngsync-on-vscode-EDITED.pngThe issue counted seven pure VS Code shots. Opening them puts the count at six, because
open-on-vscode-EDITED.pnghas the old folder namevs-launcher-es-ESselected in the file picker right where the page's text saysriftlauncher-xx-XX, which makes it project-specific after all. Two more are worth a second look for a different reason:change-main-lang-EDITED.pngand the two explorer shots list eight locales when there are thirteen languages wired intoi18n.tstoday, and the window title in three of them reads VSL.The new capture
riftlauncher-home.pngis the home page of a build of this branch, 1280 by 720, which is the launcher's own default window size and close to what the old shot used. It shows the current sidebar with Home, Installations, VS Versions, Mods, Config and Info & Help, the "Welcome to RiftLauncher" heading, the bundled background, and the 1.22 trailer card the home page loads. No MVL promotion, because that is gone from the app.Nothing personal is in it. The launcher was started against a config home of its own, seeded before launch with two plainly named Installations (Vanilla 1.20.7 and Modded Survival) and one registered game version, no accounts, and the ModDB listing question already answered so no prompt could sit on top of the shot. The session button therefore reads "Log in", which is the honest state for a launcher nobody has signed into, and the installation selector at the bottom left shows Vanilla 1.20.7 with 0 mods, which is true of the folder it points at.
The file is 621 KB, above the 300 KB the rest of the assets sit at. Cutting it to a 256-colour palette gets it to 128 KB and puts visible banding across the whole background scene, which is a worse picture of the app than a large file is a problem, so it stays lossless. It still replaces a 944 KB original.
The old name pinned a version that has not been current for a long time and named the wrong project, so the file is
riftlauncher-home.pngnow anddocs/README.mdis the only place that had to change. Its caption used to apologise for the picture being VS Launcher. It does not need to any more.What is left, in the order worth doing it
Someone with a browser, a GitHub account and VS Code can clear the rest in one sitting. Fork
StratumServer/RiftLauncherunder a throwaway name likeriftlauncher-es-ES, and the first six fall out of walking the translation page's own steps end to end:fork-EDITED.png, the repository front page with the Fork button circled. Anonymous, no account needed for the picture itself.new-fork-EDITED.png, the Create a new fork form with the name field filled in asriftlauncher-xx-XX.copy-clone-EDITED.png, the fork's front page with the Code dropdown open on the HTTPS URL.open-on-vscode-EDITED.png, VS Code's Open Folder dialog with the clonedriftlauncher-xx-XXfolder selected. Worth doing in English rather than Galician this time.pr-EDITED.pngandcreate-pr-EDITED.png, the Contribute dropdown and the comparison page, which is where a reader is most likely to be looking at the wrong repository name while trying to follow along.sync-new-changes-EDITED.png, the Sync fork dropdown. The page's own hint admits the button is missing from the current shot, so this one can be improved rather than merely refreshed.edit-lang-list-EDITED.pngandadd-new-lang-EDITED.png, which need the repository open in VS Code and would then show all thirteen locale files instead of eight.The six pure VS Code dialogs can stay until VS Code's interface moves. They teach the reader where to click, and where to click has not changed.
One thing from the issue I could not settle:
docs/SUMMARY.mdlinks../PRIVACY.md, the only link in the book that climbs abovedocs/, and there is still no.gitbook.yamlpinning the root. It resolves on disk. Whether it resolves on the published site needs someone to open the published book and click it, which is the same missing browser that keeps the rest of this list open.Gates
npx prettier --check docs/README.mdpasses.npm run typecheckpasses across node, web and tests, which it should, since the only non-image change in this branch is one line of markdown.