Skip to content

Expose fine-mapping credible-set knobs + L/L_greedy defaults in the GWAS RSS workflow#1376

Merged
danielnachun merged 1 commit into
StatFunGen:mainfrom
Yining97:rss-finemap-knobs
Jun 23, 2026
Merged

Expose fine-mapping credible-set knobs + L/L_greedy defaults in the GWAS RSS workflow#1376
danielnachun merged 1 commit into
StatFunGen:mainfrom
Yining97:rss-finemap-knobs

Conversation

@Yining97

Copy link
Copy Markdown
Contributor

Summary

Surfaces pecotmr::fineMappingPipeline's credible-set controls through the GWAS RSS workflow, which
previously only forwarded --methods, --coverage, and --method-args.

  • fine_mapping.R: new --min-abs-corr, --pip-cutoff, --secondary-coverage, and
    --median-abs-corr flags, passed to fineMappingPipeline (the last only when set, so the script
    still runs against a pecotmr that predates that argument). New --L / --L-greedy default the
    SuSiE fit to 20 / 5, seeded into the per-method kwargs with --method-args overriding per key.
  • gwas_rss_fine_mapping.ipynb: exposes all of the above as [global] parameters and forwards them
    in the gwas_fine_mapping step.

Validation

Against the matching pecotmr (below) on real chr21 ADSP LD + AD_Bellenguez: full sos run completes;
--min-abs-corr and --median-abs-corr both tune the recovered credible sets (1→2); --method-args
L-override changes the fit; the top_loci carries af; and a sos run matches a direct
fine_mapping.R call (PIP / af / CS identical).

Depends on

--median-abs-corr and the af output column require the pecotmr change in
StatFunGen/pecotmr#530 (and a susieR whose susie_get_cs has median_abs_corr). Merge that first.

…he GWAS RSS workflow

fine_mapping.R gains --min-abs-corr, --pip-cutoff, --secondary-coverage, and
--median-abs-corr, passed through to fineMappingPipeline (medianAbsCorr only
when set, so it still runs against a pecotmr without that argument). --L and
--L-greedy default the SuSiE fit to 20 / 5, seeded into the per-method kwargs
with --method-args overriding. gwas_rss_fine_mapping.ipynb surfaces all of
these as parameters.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@danielnachun danielnachun merged commit 6de571d into StatFunGen:main Jun 23, 2026
@Yining97 Yining97 deleted the rss-finemap-knobs branch June 24, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants