Expose fine-mapping credible-set knobs + L/L_greedy defaults in the GWAS RSS workflow#1376
Merged
Merged
Conversation
…he GWAS RSS workflow fine_mapping.R gains --min-abs-corr, --pip-cutoff, --secondary-coverage, and --median-abs-corr, passed through to fineMappingPipeline (medianAbsCorr only when set, so it still runs against a pecotmr without that argument). --L and --L-greedy default the SuSiE fit to 20 / 5, seeded into the per-method kwargs with --method-args overriding. gwas_rss_fine_mapping.ipynb surfaces all of these as parameters. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces
pecotmr::fineMappingPipeline's credible-set controls through the GWAS RSS workflow, whichpreviously only forwarded
--methods,--coverage, and--method-args.fine_mapping.R: new--min-abs-corr,--pip-cutoff,--secondary-coverage, and--median-abs-corrflags, passed tofineMappingPipeline(the last only when set, so the scriptstill runs against a pecotmr that predates that argument). New
--L/--L-greedydefault theSuSiE fit to 20 / 5, seeded into the per-method kwargs with
--method-argsoverriding per key.gwas_rss_fine_mapping.ipynb: exposes all of the above as[global]parameters and forwards themin the
gwas_fine_mappingstep.Validation
Against the matching pecotmr (below) on real chr21 ADSP LD + AD_Bellenguez: full
sos runcompletes;--min-abs-corrand--median-abs-corrboth tune the recovered credible sets (1→2);--method-argsL-override changes the fit; the
top_locicarriesaf; and asos runmatches a directfine_mapping.Rcall (PIP / af / CS identical).Depends on
--median-abs-corrand theafoutput column require the pecotmr change inStatFunGen/pecotmr#530 (and a susieR whose
susie_get_cshasmedian_abs_corr). Merge that first.