Skip to content

Add target whitelist for gas fund operations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gakarot-sbs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add target whitelist for gas fund operations #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/ClaimPool.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ contract ClaimPool {
// Security
uint256 public maxBatchSize;
mapping(bytes32 => bool) public processedRedemptions; // Double-spend prevention
mapping(address => bool) public approvedTargets; // For gas fund operations, whitelist of approved target addresses (defense in depth)

// ─── Events ────────────────────────────────────────────────────────

Expand All @@ -60,6 +61,7 @@ contract ClaimPool {
event OperatorChanged(address indexed oldOperator, address indexed newOperator);
event GasManagerChanged(address indexed oldManager, address indexed newManager);
event DepositPoolSet(address indexed depositPool);
event TargetWhitelisted(address indexed target, bool approved);

// ─── Errors ────────────────────────────────────────────────────────

Expand All @@ -71,6 +73,7 @@ contract ClaimPool {
error InvalidAddress();
error InvalidArrayLength();
error AlreadyConfigured();
error TargetNotWhitelisted();

// ─── Modifiers ─────────────────────────────────────────────────────

Expand Down Expand Up @@ -248,6 +251,7 @@ contract ClaimPool {
string calldata purpose
) external onlyGasManager validAddress(target) {
if (amount == 0) revert InvalidAmount();
if (!approvedTargets[target]) revert TargetNotWhitelisted();
if (gasFundBalance[token] < amount) revert InsufficientBalance();

gasFundBalance[token] -= amount;
Expand Down Expand Up @@ -290,6 +294,7 @@ contract ClaimPool {
string calldata purpose
) external onlyGasManager validAddress(target) {
if (amount == 0) revert InvalidAmount();
if (!approvedTargets[target]) revert TargetNotWhitelisted();
if (token == ETH) revert InvalidAddress();
if (gasFundBalance[token] < amount) revert InsufficientBalance();
if (data.length == 0) revert InvalidArrayLength();
Expand Down Expand Up @@ -339,6 +344,21 @@ contract ClaimPool {
emit OperatorChanged(old, newOperator);
}

/**
* @notice Adds or removes a target address from the whitelist for Gas Manager operations
* @param target The external contract address to authorize or revoke
* @param approved Boolean indicating if the target is permitted for interaction
* @dev Enforces strict protocol boundaries. Prevents arbitrary interactions with token
* contracts to ensure redemption balances remain strictly isolated, while permitting
* the gas fund to route through vetted integrations. This defense-in-depth
* measure ensures the Gas Manager operates within a predictable, restricted execution environment.
*/
function setApprovedTarget(address target, bool approved) external onlyOperator {
if (target == address(0)) revert InvalidAddress();
approvedTargets[target] = approved;
emit TargetWhitelisted(target, approved);
}

// ─── View Functions ────────────────────────────────────────────────

function getPoolStats(address token) external view returns (
Expand Down