Fix host tool selection in armhf cross builds - #66
Draft
tzhengus wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fix four host/target mismatches in the armhf cross-build path, as four focused commits:
esbuild:nativebecause the build host executes esbuild;rustfmt:nativebecause source generation executes rustfmt;run_binary.pyprependHOST_EXEC_WRAPPERwhen set;dump_app_syms.pywrap the targetdump_symsbinary while leaving the later systemstripcommand native.Tracks #62.
Why
With
dpkg-buildpackage -B --host-arch armhf -Pcrosson an x86-64 Trixie builder, unqualified build-tool dependencies resolve to armhf and cannot be executed natively. Chromium 150 also has runners that execute generated armhf helpers without thecross-exe-wrapperpath already used elsewhere in the Debian packaging.These changes affect build dependencies and build-time process launching only; they do not change Chromium runtime behavior.
Validation
HOST_EXEC_WRAPPERis applied to the intended target binary;.deboutput, is still running.This PR is intentionally a draft. I will add the final armhf package result before marking it ready. The four commits can be split into separate PRs if that is easier to review.