Refactoring Launch FIles#51
Conversation
zbrotherton
left a comment
zbrotherton
left a comment
There was a problem hiding this comment.
I need to look into this deeper, but at first glance it looks like you're deleting vital launch components
Pull from develop so we're sure I'm only looking at your changes?
| Node = [ | ||
| ] | ||
|
|
||
| return LaunchDescription(declared_arguments + Node) |
There was a problem hiding this comment.
This won't work. We need nav2 to be part of our launch description, otherwise this launch file will not function
There was a problem hiding this comment.
You added the description to our arguments? I'm confused
There was a problem hiding this comment.
The commit 301767d should have solved the issue.
| nav2 = IncludeLaunchDescription( | ||
| PythonLaunchDescriptionSource(nav2_launch_path), | ||
| launch_arguments={ | ||
| 'params_file' : config_path | ||
| }.items() | ||
| ) |
There was a problem hiding this comment.
Remove all commented out code blocks - this goes against the point of using git
There was a problem hiding this comment.
The commit 301767d should have solved the issue.
| declared_arguments.append( | ||
| DeclareLaunchArgument( | ||
| name="use_sim", | ||
| default_value="false", | ||
| description="Wether or not the robot is launching in simulation" | ||
| ) | ||
| ) | ||
|
|
||
| use_sim = LaunchConfiguration("use_sim") | ||
|
|
There was a problem hiding this comment.
Confused why you're removing these.
| #TODO | ||
| linear.x.has_jerk_limits: false | ||
| linear.x.max_jerk: 0.0 | ||
| linear.x.min_jerk: 0.0 | ||
| # #TODO | ||
| # linear.x.has_jerk_limits: false | ||
| # linear.x.max_jerk: 0.0 | ||
| # linear.x.min_jerk: 0.0 |
There was a problem hiding this comment.
Why did you comment these out?
There was a problem hiding this comment.
i didn't do that though ;(
…PI-IGVC-2025/RobotCode2026 into feature/Refractor-Launch-Files
|
Non-critical for competition |
5 participants
No description provided.