Feature/robot self filter#123
Open
ashvinganesan wants to merge 6 commits into
Open
Conversation
# Conflicts: # src/igvc_nav/config/nav2_params.yaml
TagCiccone
previously requested changes
Apr 10, 2026
Member
There was a problem hiding this comment.
When building robot_self_filter with colcon, a dev warning comes up. It's not an error, so we can supress it.
In colcon.meta: Add
robot_self_filter:
cmake-args:
- "-DCMAKE_POLICY_DEFAULT_CMP0144=NEW"
to the end of the file.
(colcon.meta exists on /develop, so either merge develop into this branch or copy it wholesale)
Contributor
Author
copied the file and added the change. |
still showing up as requesting change even when I do rerequest (not sure why) I made the changes
Glesko22
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the robot-self filter package. This means that the robot doesn't see itself and think that it is hitting a wall/object. #107