No std hashing - #6333
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
I'm having some trouble with the UI tests. They are still failing even after running it with |
0b30e55 to
cbdfc5b
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for iterating through the ways forward here. I'm not entirely sure about the consequences of adding the ahash dependency or switching the hashing to it.
Would an acceptable alternative be to make the #[pyclass(hash)] option require the std feature for now? We might yet proceed with this option later, but deferring by gating the functionality might be good enough to unblock you?
Yes, this would be a good way to unblock this for now. |
I haven't really thought it through thoroughly either, I just wanted to see if something like this could be done so that a properly thought out choice could be implemented later. |
Closes #6329
I've added a new trait in
impl_:PyHashable. I usedahash::randome_state::RandomStateas the build hasher but that can be replaced by anyBuildHasherthat can be constructed at compile time.