internal: don't generate hash functions if no_std - #6343
Open
Person-93 wants to merge 8 commits into
Open
Conversation
Person-93
force-pushed
the
no_std_no_hashing
branch
from
August 23, 2026 01:44
75b3ed5 to
f616705
Compare
Member
|
I opened Person-93#1 targeting this branch, which hopefully unblocks you with the UI tests. |
Person-93
force-pushed
the
no_std_no_hashing
branch
from
August 23, 2026 22:10
72f0845 to
86a330c
Compare
Person-93
marked this pull request as ready for review
August 24, 2026 14:41
davidhewitt
reviewed
Aug 25, 2026
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
Thanks, generally looks good, I would like the error message adjusted please.
(Note that nox -s update-ui-tests only updates the .stderr files, the expectations in the input .rs files need to be updated by hand.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've disabled the
hashoption when not usingstdas discussed here.The ui tests do not pass for
no_stdas it now emits a compile error message about hashing functions not being available without thestdfeature. I am not sure how to proceed with this.I've labeled this as internal because
no_stdis not user-visible yet.