Fix stale rollout success state and preserve LIBERO replay videos#965
Open
Anirudh-Kavle wants to merge 1 commit into
Open
Fix stale rollout success state and preserve LIBERO replay videos#965Anirudh-Kavle wants to merge 1 commit into
Anirudh-Kavle wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two small improvements to
examples/libero/main.py:1. Reset episode success state
donewas not initialized before entering the episode loop, so if an exception occurs before env.step() runs, the previous episode's value carries over. This can cause a failed episode to be incorrectly saved and logged as a success. Fixed by addingdone = Falseat the start of each episode.2. Preserve replay videos across episodes
Replay videos were previously saved using filenames based only on task description and success/failure suffix, causing later episodes to overwrite earlier ones. This makes failure analysis unreliable, since a later success can overwrite an earlier failure video. Added
ep{episode_idx:03d}to the filename so all rollout videos are preserved.Neither change affects evaluation metrics or rollout behavior.