Refine bilingual UI copy - #123
Merged
Merged
Conversation
added 2 commits
August 31, 2026 20:53
PathGao
added a commit
that referenced
this pull request
Sep 1, 2026
…127) #123 was a bilingual copy pass — its own description says no behaviour, persistence or settings semantics changed — but it also rewrote MARKETING_VERSION from 0.1.3 to 8.8.8. Nothing reads that value until a release does, so it sat on main unnoticed. Config.xcconfig is the only place a version is written, and release.yml derives the tag from it. Releasing from main as it stood would have created an immutable v8.8.8 and left every later version having to exceed it. 0.9.0 rather than 0.1.4: the 115 pull requests since v0.1.3 include playlists, the per-display panel that replaced the menu, the new icon and the bilingual UI, which is not a patch. Co-authored-by: PathGao <gaoyanbo@gaoyanbodeMacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
xcodebuild build -project Nifro.xcodeproj -scheme Nifro -configuration Debug -destination 'platform=macOS' -derivedDataPath .xcode-build CODE_SIGNING_ALLOWED=NO\n-python3 Tools/check-strings.py .xcode-build\n-swift test(221 tests in 49 suites)\n-git diff --check\n\nNo behavior, persistence, or settings semantics changed.