The version number is 0.9.0, not the 8.8.8 a copy change left behind - #127
Merged
Conversation
#123 was a bilingual copy pass — its own description says no behaviour, persistence or settings semantics changed — but it also rewrote MARKETING_VERSION from 0.1.3 to 8.8.8. Nothing reads that value until a release does, so it sat on main unnoticed. Config.xcconfig is the only place a version is written, and release.yml derives the tag from it. Releasing from main as it stood would have created an immutable v8.8.8 and left every later version having to exceed it. 0.9.0 rather than 0.1.4: the 115 pull requests since v0.1.3 include playlists, the per-display panel that replaced the menu, the new icon and the bilingual UI, which is not a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
MARKETING_VERSIONgoes from8.8.8to0.9.0. One line inConfig.xcconfig.Mechanism
#123 was a bilingual copy pass, and its description says no behaviour, persistence or settings semantics changed. It also rewrote
MARKETING_VERSIONfrom0.1.3to8.8.8:Nothing in the app or in CI reads that value —
release.ymlis the only consumer, and only a release runs it — so it sat onmainfor a day without anything going red.That matters because
release.ymlderives the tag from it (sed -n 's/^MARKETING_VERSION *= *//p' Config.xcconfig), and the tag is created bygh release create --target $GITHUB_SHAas the last step. Releasing frommainas it stood would have publishedv8.8.8— a ref theversion tagsruleset forbids moving or deleting — and left every later version having to sort above it, in the Release list and in the cask.Scope
0.9.0rather than0.1.4. The 115 pull requests since v0.1.3 include websites becoming playlists (#64), the per-display panel that replaced the menu (#21), per-display state leaving app-wide slots (#61), the new icon (#119, #122) and the bilingual UI (#118, #123). That is not a patch.Left alone:
CURRENT_PROJECT_VERSION, which stays1— it has never been bumped in this repository and nothing reads it. TheCasks/nifro.rbversion is not touched here either; the release workflow opens its own pull request for that.Verification
grep -rn '8\.8\.8'across the tree returns nothing outside the line this changes, confirmingdocs/RELEASE.md's claim thatConfig.xcconfigis the only place a version is written.git taghas nov0.9.0, so the workflow's "tag already exists" precondition passes.release.ymlis unchanged since v0.1.3, so perdocs/RELEASE.mda dry run is not required for this release.