Fix wildcard detection (#11), dead repo URLs, and duplicate CI steps - #29
Open
Dishanth234 wants to merge 1 commit into
Open
Fix wildcard detection (#11), dead repo URLs, and duplicate CI steps#29Dishanth234 wants to merge 1 commit into
Dishanth234 wants to merge 1 commit into
Conversation
Author
|
Hi @hermanerr, @chriskrycho first-time contributor here. This bundles the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detectors: colon-syntax prefix wildcards (
Bash(cmd:*)— the form ClaudeCode writes for "always allow") now classify the same as the equivalent space
form (
Bash(cmd *)), and bare tool-wide wildcards such asBash(*)areflagged OVERBROAD instead of safe.
Bash(*)reuses the existing OVERBROADcategory rather than adding a new severity tier — happy to adjust if you'd
prefer it ranked higher. Two detector tests added.
Docs/UI: dead
VantaInc/grantguardlinks (404 since the org rename) nowpoint to
OpenVanta/GrantGuard— the CONTRIBUTING clone command, thechangelog link references, the issue chooser's security-advisory link, and
both spots in the web UI share modal. Also points the oxfmt link at its live
docs page. This revives the approved-but-unmerged #10 (credit to
@imran-siddique).
CI: removes the duplicated
setup-pythonv6.3.0 /checkoutv7.0.0steps left behind by a merge conflict resolution, so each job checks out and
sets up Python exactly once. Also obsoletes the dependabot re-bump in #28.
Verified: 90/90 tests on Python 3.10 and 3.12,
compileallclean,pnpm fmt:checkpasses, no newpnpm checkerrors, every replacement URLreturns 200.
Related issue
Closes #11
Type of change
Checklist
uv run python -m compileall -q grantguard grantguard.pypassesredact()(n/a — no new secret patterns; the added detectors are non-redacting)