Skip to content

Fix ModCollectionPath folder nesting - #1274

Merged
shananas merged 2 commits into
OpenKH:masterfrom
tryashtar:mod-path-fix
Aug 15, 2026
Merged

Fix ModCollectionPath folder nesting#1274
shananas merged 2 commits into
OpenKH:masterfrom
tryashtar:mod-path-fix

Conversation

@tryashtar

Copy link
Copy Markdown
Contributor

By default, the tool looks for mods in <root>/mods.

You can change the modCollectionPath option in mods-manager.yml to make it look somewhere else instead. However, currently this makes it look in <path>/mods, instead of just <path>.

This PR fixes this without affecting the default <root>/mods location.

Previously, customizing ModCollectionPath resulted in the tool looking in a "mods" folder inside of the provided folder.
Now, it looks directly in the provided folder.
The "mods" subfolder is now only the fallback when the key is not customized.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6641c753-77af-4056-a245-a8e03cea2568

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shananas

Copy link
Copy Markdown
Collaborator

Both the installed mods and built mod folder use modCollectionsPath in get so this happens to separate installed mods into one subfolder and built mods into another im going to fix this bug and while im at it rename these variables to be less confusing. Ill add this change to that for both mods and mod.

image

as seen here the ahh folder isnt used at all. well i deleted it but it stayed empty build mods went into the mod folder

@tryashtar

tryashtar commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Hm, yeah, the GameModPath has a typo in the getter. I'll push a fix for that too.

@shananas shananas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically introduces a bug if ModCollectionsPath and GameModsPath are the same but im fixing it while renaming these variables to be less confusing

@shananas
shananas merged commit 43c413a into OpenKH:master Aug 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants