docs: sweep stale version claims in conformance/validator docs#5
Closed
BunsDev wants to merge 1 commit into
Closed
docs: sweep stale version claims in conformance/validator docs#5BunsDev wants to merge 1 commit into
BunsDev wants to merge 1 commit into
Conversation
Post-merge code review of 65622c0..710036e found current-version claims the v0.3.0 sweep missed (CHANGELOG sweep list omitted these files): - tests/conformance/README.md: suite titled/defined as v0.2 while RFC-0001 §6.1 defines this exact suite as the v0.3.0 conformance criterion (Medium) - validators/README.md: claimed v0.1.0 compliance + stale sample output, two bumps behind the binary it documents (Low, pre-existing) - negative/09-missing-memory/CASE.md: said missing MEMORY.md 'is a warning only' — false since v0.2.0 promoted it to a violation (Low, pre-existing) Docs only; validator and fixtures untouched. Suite re-verified: 5/5 positive + 10/10 negative, READY. Refs coven-threads bead threads-auu. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates documentation under the conformance suite and validator docs to remove stale “current version” claims and align stated compliance level with RFC-0001 v0.3.0.
Changes:
- Bump
validators/README.mdstated compliance/output from v0.1.0 → v0.3.0. - Bump
tests/conformance/README.mdsuite title/definition from v0.2 → v0.3.0. - Update
tests/conformance/negative/09-missing-memory/CASE.mdto reflect the v0.2.0 warning→violation promotion and current expected validator behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| validators/README.md | Updates stated validator compliance/output version to v0.3.0. |
| tests/conformance/README.md | Updates suite version claims/definition to v0.3.0. |
| tests/conformance/negative/09-missing-memory/CASE.md | Clarifies expected failure semantics for missing MEMORY.md and references the relevant RFC requirement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Familiar Contract v0.3.0 Conformance Suite | ||
|
|
||
| This directory is the testable form of the Familiar Contract: a set of fixture familiars that encode the five normative properties as executable validator expectations. It uses the current repository validator as the conformance oracle while documenting where v0.2 expectations are stricter than the current implementation. | ||
| This directory is the testable form of the Familiar Contract: a set of fixture familiars that encode the five normative properties as executable validator expectations. It uses the current repository validator as the conformance oracle while documenting where v0.3.0 expectations are stricter than the current implementation. |
Member
Author
|
Superseded by v0.4.0 (f70c796): main independently re-swept tests/conformance/README.md and rewrote validators/README.md + validate.js, absorbing this PR's version-claim fixes at the new baseline. The one surviving fix — negative/09-missing-memory/CASE.md's false 'warning only' claim — carries into the v0.4.1 re-cut of PR #6. Bead: threads-auu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge code review of
65622c0..710036e(RFC-0001 v0.3.0, PR #3) found current-version claims the sweep missed — the CHANGELOG sweep list (README.md, rfcs/README.md, SPEC.md, docs/faq.md, validate.js) omitted these files:tests/conformance/README.mdvalidators/README.mdnegative/09-missing-memory/CASE.mdVerification
validators/, fixtures, schemas untouched by this diffbash tests/conformance/run-conformance.sh: 5/5 positive + 10/10 negative, READYMEMORY.md does not exist)Refs coven-threads bead
threads-auu(review findings recorded there). Follow-up to #3.