Skip to content

rfc(0001): v0.4.1 — definitional completions and conformance-doc corrections#7

Merged
BunsDev merged 1 commit into
mainfrom
rfc/0001-v041-definitional-nits
Jul 22, 2026
Merged

rfc(0001): v0.4.1 — definitional completions and conformance-doc corrections#7
BunsDev merged 1 commit into
mainfrom
rfc/0001-v041-definitional-nits

Conversation

@BunsDev

@BunsDev BunsDev commented Jul 22, 2026

Copy link
Copy Markdown
Member

RFC-0001 v0.4.1 (draft patch)

Re-cut of superseded PRs #5/#6 against the v0.4.0 baseline — main moved beneath that stack when #4 merged (f70c796), absorbing their version sweeps but not the definitional nits or the conformance-doc falsehood, which land here.

Patch classification (new §6.3): draft patch — clarifications only; no conformance requirements change. Prior Nova-lane PASS on the identical normative delta: #6 (comment 5041608668).

Normative text (clarifying)

  • §1.1 (NEW-N-3)standard admission path definition now names the §3.4 loop-origin authorization step the path already performs.
  • §5.6 (NEW-N-1) — evidence-field SHOULD-list bullets now carry (MUST — see below) pointers; the principal_authorization bullet's condition now includes loop-originated memory_entry_admitted events (matching the MUST paragraph verbatim).

Conformance-doc corrections

  • negative/09-missing-memory/CASE.md — removed the false claim that missing MEMORY.md is reported "as a warning only" (violation since v0.2.0; verified against the v0.4.0 Ajv validator: exit 1, Persistent Memory ✗). Stale v0.2 anchor dropped.
  • positive/05-tier-rich-ward/CASE.md — tier names now cite RFC-0001 §5.3 instead of "the v0.2 RFC frame" (prior review N-1).

Version sweep → v0.4.1

RFC header/abstract/§6.1×2/§6.3/§10.1/footer + §11 entry; CHANGELOG [0.4.1]; README (badge + 5 claims); PRIMER.md; SPEC.md banner; docs/faq.md ×3; rfcs/README.md (table/citation/tag URL); tests/conformance/README.md; validators/README.md ×4; validate.js banner; package.json + lock. Untouched by design: historical changelog/§11/snapshot refs, PROVENANCE.md, docs/ward-deep-dive.md (intentionally pinned to the v0.3.0 snapshot), superpowers plan docs (historical).

Verification

  • bash tests/conformance/run-conformance.sh6/6 positive, 36/36 negative, READY
  • node validators/validate.js examples/minimal and examples/sage → PASS, banner v0.4.1
  • residual v0.4.0 grep: historical positions only

Gates

Fresh-context Nova-lane review → Val approval → merge → tag v0.4.1.

Bead: threads-auu

…ections

Draft patch per §6.3: clarifications only, no conformance change.
Re-cut of superseded PRs #5/#6 against the v0.4.0 baseline (f70c796).

- §1.1: complete the standard-admission-path definition with the §3.4
  loop-origin authorization step the path already performs (NEW-N-3)
- §5.6: annotate the evidence-field SHOULD-list with per-event-type MUST
  pointers to the upgrading paragraph, incl. principal_authorization on
  loop-originated memory_entry_admitted events (NEW-N-1)
- negative/09 CASE.md: correct false 'warning only' claim (violation
  since v0.2.0); positive/05 CASE.md: cite §5.3 instead of 'v0.2 frame'
- §11/CHANGELOG: v0.4.1 entries; sweep current-version refs to v0.4.1
  (README, PRIMER, SPEC, faq, rfcs/README, conformance+validator
  READMEs, validate.js banner, package.json+lock); historical refs and
  the deep-dive's intentional v0.3.0 pin untouched

Conformance: 6/6 positive, 36/36 negative, READY; both examples PASS.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BunsDev

BunsDev commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

Fresh-context Nova-lane review — verdict: PASS

Reviewed at pinned ae97f11 (single commit on f70c796, merge-base confirmed) in a detached worktree.

a. Draft-patch classification (new §6.3) — SOUND. NEW-N-3's §1.1 wording describes an obligation verbatim-present in §3.4 since the v0.3 snapshot; NEW-N-1's three bullet annotations match the unchanged MUST paragraph word-by-word (pre-change, the principal_authorization bullet understated it). Even read as inline normative keywords, the annotations impose requirements identical to the existing paragraph — no conformance delta. No interaction with §5.3.1.

b. Internal consistency — CLEAN. §1.1 ↔ §3.4 agree; §5.6 bullets ↔ MUST paragraph agree on event types + loop-originated condition; reinforces §3.4's provenance-vs-authorization distinction.

c. CASE.md corrections — NOW TRUE. Fixture 09 re-run: exit 1, MEMORY.md does not exist, Persistent Memory ✗. Bonus: the old 'warning only' text was false from birth808ae16 introduced fixture 09 and the violation behavior in the same commit; only the pre-RFC v0.1.0 validator warned. positive/05: §5.3 names exactly the four cited tiers.

d. Version sweep — COMPLETE. Residual v0.4.0 hits are historical only (CHANGELOG/§11 history, self-pinned deep-dive, superpowers plans). No historical file appears in the diff.

e. Conformance — GREEN. 6/6 positive, 36/36 negative, READY; both examples PASS; banner v0.4.1.

f. Changelog/§11 — ACCURATE. 'Violation since v0.2.0' verified against the v0.2 snapshot (line 134) and validator history.

Findings

  • Blocking: none.
  • A-1: rfcs/README.md:66 cites releases/tag/v0.4.1 which doesn't exist until merge — the adjacent 'until then, cite the latest existing tag' caveat covers the window; maintainer must cut tag v0.4.1 at merge (already the documented plan).
  • N-1..N-3 (editorial, not applied): §5.6 bullet's 'or…and when' chain could read 'or when' for parallelism (MUST paragraph disambiguates regardless); CHANGELOG sweep bullet omits package-lock.json; negative/09 CASE.md parenthetical glosses the validator message rather than literal §3.4 text. Left as-is to keep the reviewed SHA pinned — Val may request them pre-merge.

Remaining gate

Val approval → mark ready → merge → tag v0.4.1 at the merge commit.

Bead: threads-auu.

@BunsDev
BunsDev marked this pull request as ready for review July 22, 2026 09:41
Copilot AI review requested due to automatic review settings July 22, 2026 09:41
@BunsDev
BunsDev merged commit 8a2dfd2 into main Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates RFC-0001 and repository documentation to v0.4.1 as a draft patch, clarifying existing cross-references (no conformance-requirements change) and correcting conformance-suite documentation that previously misstated validator behavior.

Changes:

  • Bump current-version references across the RFC, docs, validator banner, and package metadata to v0.4.1.
  • Clarify RFC-0001 definitions and audit-log evidence-field bullets to explicitly point at existing MUST-level requirements.
  • Fix conformance-case documentation anchors (notably the missing MEMORY.md case) and add v0.4.1 entries to changelogs.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
validators/validate.js Updates CLI banner to v0.4.1 (version sweep).
validators/README.md Updates validator documentation and sample output to v0.4.1.
tests/conformance/README.md Updates conformance-suite title/claim text to v0.4.1.
tests/conformance/positive/05-tier-rich-ward/CASE.md Reanchors tier-name citation to RFC-0001 §5.3.
tests/conformance/negative/09-missing-memory/CASE.md Corrects description of missing MEMORY.md behavior and anchors to RFC-0001 §3.4.
SPEC.md Updates “current normative specification” pointer to RFC-0001 v0.4.1.
rfcs/RFC-0001-familiar-contract.md Bumps RFC to v0.4.1; clarifies definition + audit-log bullets; adds v0.4.1 changelog entry.
rfcs/README.md Updates RFC index and citation examples to v0.4.1.
README.md Updates badge and usage text to v0.4.1.
PRIMER.md Updates normative spec reference to v0.4.1.
package.json Bumps package version to 0.4.1.
package-lock.json Bumps lockfile version fields to 0.4.1.
docs/faq.md Updates FAQ references to RFC-0001 v0.4.1.
CHANGELOG.md Adds 0.4.1 entry and summarizes the clarifications/doc corrections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread validators/validate.js
}

console.log(`\n${bold('familiar-contract validator')} ${dim('v0.4.0')}`);
console.log(`\n${bold('familiar-contract validator')} ${dim('v0.4.1')}`);
@BunsDev
BunsDev deleted the rfc/0001-v041-definitional-nits branch July 22, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants