Skip to content

Don't mark received messages as failed on receipt errors #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankBStack wants to merge 1 commit into
base: rustpush
Choose a base branch
from
+7 −1
Open

Don't mark received messages as failed on receipt errors #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/services/rustpush/rustpush_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3558,8 +3558,14 @@ class RustPushService extends GetxService {
if (myMsg.message is api.Message_Error) {
var message = myMsg.message as api.Message_Error;
var mistakeFor = Message.findOne(guid: message.field0.forUuid);
// if we've been delivered, well :shrug: probably some stray device complaining
// if we've been delivered, well :shrug: probably some stray device complaining
if (mistakeFor == null || mistakeFor.isDelivered) return; // multiple errors will likely come in, at which point guid will be bad.
// delivered/read receipts reuse the original message's UUID (see markCertified/markRead), so an error
// for a message we didn't author is a rejected receipt, not a send failure. Don't flag the received message.
if (mistakeFor.isFromMe != true) {
Logger.debug("Ignoring error ${message.field0.statusStr} for receipt on ${message.field0.forUuid}");
return;
}
// do not flag 300 error messages for self handles
var myHandles = (await api.getHandles(state: pushService.state!.client));
if (!myHandles.contains(myMsg.sender)) return;
Expand Down