Don't mark received messages as failed on receipt errors - #260
Open
FrankBStack wants to merge 1 commit into
Open
Don't mark received messages as failed on receipt errors#260FrankBStack wants to merge 1 commit into
FrankBStack wants to merge 1 commit into
Conversation
Delivered and read receipts reuse the UUID of the message they're acknowledging, so when a receipt is rejected the error comes back keyed to a message we didn't send. That was flagging incoming messages with a send failure. Ignore errors for messages that aren't from us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivered/read receipts are sent with the UUID of the message they acknowledge (see
markCertified/markRead). When one of those receipts gets rejected, the resultingMessage_Erroris keyed to that same UUID, which is a message we received, not one we sent. The error handler then flagged the incoming message with a send failure.This skips error handling for messages that aren't from us. Real send failures on our own messages are handled exactly as before.
Related: #206 and #61 are in this same handler but concern self-reflection errors on our own sends, which this does not change.