Remove library headers from non-main files - #179
Merged
Conversation
etu
approved these changes
Jan 17, 2023
Member
Author
|
I am on mobile now, so I'll fix this later. |
Member
Author
I think it's ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
Package-Requiresheader in non-main files can mislead contributors. MELPA reads the header only from the "main file" of the package, so if a contributor adds a new dependency to the header in a wrong file, it causes a missing dependency (as in #177).Unless this repository is distributed as multiple packages, only
nix-mode.elis supposed to contain the header. This PR removes the dependency header from source files other than the main file.