Skip to content

add missing Package-Requires declaration in nix-store.el header - #187

Closed
pasunboneleve wants to merge 2 commits into
NixOS:masterfrom
pasunboneleve:fix/magit-dependency-in-emacs-lisp-header
Closed

add missing Package-Requires declaration in nix-store.el header#187
pasunboneleve wants to merge 2 commits into
NixOS:masterfrom
pasunboneleve:fix/magit-dependency-in-emacs-lisp-header

Conversation

@pasunboneleve

@pasunboneleve pasunboneleve commented May 20, 2023

Copy link
Copy Markdown

This is needed by users who rely on emacs rather than nix to install the required dependencies to nix-store.el

This is needed by users who rely on emacs rather than nix to
install the required dependencies to nix-store.el

The dependency was set to version `3.0.0` as this is the first
version where the `magit-section` package is split from `magit`.
`magit` and `magit-section` share the same release version
numbers.
@nagy

nagy commented May 20, 2023

Copy link
Copy Markdown
Member

This has just been purposefully removed recently:

The consensus was, that only the main file, in this case nix-mode.el should have this header.

@pasunboneleve pasunboneleve changed the title add missing Package-Requires declaration in nix-store.el header add missing Package-Requires declaration in nix-mode.el header May 20, 2023
@pasunboneleve pasunboneleve changed the title add missing Package-Requires declaration in nix-mode.el header add missing Package-Requires declaration in nix-store.el header May 20, 2023
@pasunboneleve

Copy link
Copy Markdown
Author

Seems that I was wrong assuming that this was the cause of the problem I'm having. I never realised I was working on nix-store.el and not nix-mode.el!

Thanks for the quick reply. I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants