Skip to content

Declare reformatter dependency in nix-mode.el - #177

Merged
etu merged 1 commit into
NixOS:masterfrom
chvp:declare-dependency-for-melpa
Jan 17, 2023
Merged

Declare reformatter dependency in nix-mode.el#177
etu merged 1 commit into
NixOS:masterfrom
chvp:declare-dependency-for-melpa

Conversation

@chvp

@chvp chvp commented Jan 14, 2023

Copy link
Copy Markdown
Member

Since #176 nix-mode is broken for me. Only the dependencies in the main nix-mode.el file seem to be picked up, so this should fix it again.

Since NixOS#176 nix-mode is broken for me. Melpa only picks up the dependencies in
the main nix-mode.el file, so this should fix it again.
@bendlas

bendlas commented Jan 14, 2023

Copy link
Copy Markdown

I've managed to work around this bug on my setup with monkey-patching:

        (updatePackage "nix-mode" (epkgs: old: {
          propagatedBuildInputs = old.propagatedBuildInputs ++ [ epkgs.reformatter ];
          propagatedUserEnvPkgs = old.propagatedUserEnvPkgs ++ [ epkgs.reformatter ];
        }))

It would be very nice to get this fixed upstream, @matthewbauer

@etu

etu commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

I hope nobody minds if I just merge this... I'm not active in this project really but I have the ability to merge and my nix-mode is currently totally broken... as is everyone else's unless you happen to have reformatter installed for other reasons.

@etu
etu merged commit 9796493 into NixOS:master Jan 17, 2023
@chvp
chvp deleted the declare-dependency-for-melpa branch January 17, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants