Skip to content

fix(test): pass required NeMo Gym rollout arguments #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 2 commits into from
Jul 23, 2026
+19 −9
Merged

fix(test): pass required NeMo Gym rollout arguments #3317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb9c78
test: pass required NeMo Gym rollout arguments
joyang-nv Jul 23, 2026
f5cc5e5
test: consume async NeMo Gym rollout results
RayenTian Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions tests/unit/experience/test_rollout_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,15 +739,25 @@ def test_async_nemo_gym_rollout_manager_matches_original(
}
)

original_result = run_async_nemo_gym_rollout(
policy_generation=nemo_gym_vllm_generation,
input_batch=repeated_batch,
tokenizer=nemo_gym_tokenizer,
task_to_env={"nemo_gym": nemo_gym},
generation_config=nemo_gym_vllm_generation.cfg,
max_seq_len=nemo_gym_vllm_generation.cfg["vllm_cfg"]["max_model_len"],
max_rollout_turns=None,
)
async def _collect_original_results():
return [
result
async for result in run_async_nemo_gym_rollout(
policy_generation=nemo_gym_vllm_generation,
input_batch=repeated_batch,
tokenizer=nemo_gym_tokenizer,
task_to_env={"nemo_gym": nemo_gym},
generation_config=nemo_gym_vllm_generation.cfg,
num_generations=num_generations,
log_full_result_tables=False,
max_seq_len=nemo_gym_vllm_generation.cfg["vllm_cfg"]["max_model_len"],
max_rollout_turns=None,
)
]

original_results = asyncio.run(_collect_original_results())
assert len(original_results) == 1
original_result = original_results[0]

manager = RolloutManager(
use_nemo_gym=True,
Expand Down
Loading