fix(test): pass required NeMo Gym rollout arguments#3317
Merged
Conversation
Member
Author
|
/ok to test 29df09e |
RayenTian
added
the
CI:Lfast
Contributor
|
/ok to test 29df09e |
Contributor
|
There's an error with nemo-gym unit test. Because PR! 3000 introduce new parameters, but PR! 3219 add this unit test and run CI before PR! 3000 merged. So the PR! 3219 CI passed without error. This PR is a correct fix. Would you please take a review for this PR, @terrykong ? Thanks a lot! |
terrykong
previously approved these changes
Jul 23, 2026
terrykong
enabled auto-merge (squash)
July 23, 2026 06:14
RayenTian
force-pushed
the
fix/nemo-gym-rollout-test-args
branch
2 times, most recently
from
July 23, 2026 06:56
8598757 to
a55ee4e
Compare
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
RayenTian
force-pushed
the
fix/nemo-gym-rollout-test-args
branch
from
July 23, 2026 07:03
a55ee4e to
f5cc5e5
Compare
Contributor
|
/ok to test f5cc5e5 |
RayenTian
changed the title
terrykong
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information