Skip to content

fix: serialize MuPDF metadata reads #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Matbe34 merged 1 commit into from
May 4, 2026
Merged

fix: serialize MuPDF metadata reads #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions internal/pdf/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,11 @@ type PageDimensions struct {
}

// GetPageDimensions returns the width and height of a page in PDF points.
// Holds an exclusive lock because MuPDF's fz_context is not safe for concurrent
// access — see also GetMetadata.
func (s *PDFService) GetPageDimensions(pageNum int) (*PageDimensions, error) {
s.mu.RLock()
defer s.mu.RUnlock()
s.mu.Lock()
defer s.mu.Unlock()

if s.doc == nil {
return nil, fmt.Errorf("no PDF document is open")
Expand All @@ -252,9 +254,11 @@ func (s *PDFService) GetPageDimensions(pageNum int) (*PageDimensions, error) {
}

// GetMetadata returns title, author, and other metadata for the open PDF.
// Holds an exclusive lock because MuPDF's fz_context is not safe for concurrent
// access; concurrent fitz.Document.Metadata() calls corrupt internal state.
func (s *PDFService) GetMetadata() (*PDFMetadata, error) {
s.mu.RLock()
defer s.mu.RUnlock()
s.mu.Lock()
defer s.mu.Unlock()

if s.doc == nil {
return nil, fmt.Errorf("no PDF document is open")
Expand Down
Loading