fix: serialize MuPDF metadata reads - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PDFService.GetMetadataandGetPageDimensionsheld `RLock` and called into MuPDF (`s.doc.Metadata()`, `s.doc.Bound()`), but MuPDF's `fz_context` is not safe for concurrent access. Two readers proceeding under `RLock` would race inside MuPDF and crash the test binary mid-run (no `--- FAIL` line, just a package-level abort).`TestConcurrentOperations` exposes this — fails ~3/5 runs locally on master. The previous green CI runs were luck.
Fix: upgrade those two methods to exclusive `Lock`. `GetPageCount` stays `RLock` (only reads a Go int, no MuPDF re-entry).
Performance impact
Negligible. Both methods are microsecond-scale MuPDF reads; the workload is a single-user desktop app with one PDF open. The "lost parallelism" was undefined behavior that segfaulted under load — not a real perf baseline. `GetPageCount` (the hot path) is unaffected.
Test plan