Skip to content

Tail-cancel on total remaining groups, not just in-flight #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightlessbaron wants to merge 1 commit into
base: prod
Choose a base branch
from
Open

Tail-cancel on total remaining groups, not just in-flight #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions miles/rollout/inference_rollout/inference_rollout_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,11 @@ async def generate_rollout_async(
data.append(group)
pbar.update(args.n_samples_per_prompt)

# One pending task == one group, so len(pendings) is the live group count;
# with oversampling off, drop the slow tail once tail_cancel_groups remain.
if args.disable_oversampling and 0 < len(pendings) <= args.tail_cancel_groups:
groups_left = (target_data_size - submitted) + len(pendings)
if args.disable_oversampling and 0 < groups_left <= args.tail_cancel_groups:
logger.info(
f"[rollout] tail-cancel: {len(pendings)} groups pending <= "
f"[rollout] tail-cancel: {groups_left} groups left "
f"({len(pendings)} in flight, {target_data_size - submitted} unsubmitted) <= "
f"{args.tail_cancel_groups}; cutting tail with {len(data)}/{target_data_size} "
f"groups collected"
)
Expand Down
Loading