Tail-cancel on total remaining groups, not just in-flight#68
Open
nightlessbaron wants to merge 1 commit into
Open
Tail-cancel on total remaining groups, not just in-flight#68nightlessbaron wants to merge 1 commit into
nightlessbaron wants to merge 1 commit into
Conversation
nightlessbaron
force-pushed
the
fix/tail-cancel-remaining-groups
branch
from
87747dd to
7a0cbff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #56. The tail-cancel condition counted only in-flight tasks, but with
--rolling-start-sizegroups are submitted in waves, early in a rollout few groups are in flight simply because most haven't been submitted yet, so the condition fired at the start and cancelled the whole batch.Compare tail_cancel_groups against total remaining work instead: unsubmitted groups plus in-flight tasks. Without rolling start everything is submitted upfront, so behavior is unchanged.