Tests of integration and advection problems with periodic boundary conditions - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test the solution of simple problems in 1D with periodic boundary conditions.
implemented using backward Euler and second-order backward Euler time differencing.
Dirichlet boundary conditions are implemented in 1D to use with integration operators in 1D. In this implementation, we need to set the value of the periodic function in two places, i.e., https://github.com/moment-kinetics/FiniteElementAssembly.jl/blob/2c08db02561cc7002d021a5c44532069ff291db2/test/PeriodicBcTests.jl#L80-L86
It would be possible to implement integration with periodic boundary conditions differently, but this would require a new type
PeriodicDirichletBC <: AbstractBoundaryCondition. A future implementation could set the first row of the 1D matrix to beand set the last row to be
so that the above code would be modified to
In this modified version, there is clearly only one available constant to set when integrating ODEs with periodic boundary conditions. However, we still require the same number of lines of code, and the need for an additional boundary condition type means that we defer the implementation of the feature this way to a future PR where it is explicitly required.