Fix the first derivative operator for DirichletBC - #5
Merged
Conversation
…nate struct can only see either a NaturalBC or a PeriodicBC. Create a function interface that returns a NaturalBC if a DirichletBC is stored in the FiniteElementCoordinate struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #3 where the
first_derivative!()operator using theFirstDerivativeData()used an incorrectDirichletBC()when assembling theMM1D(mass) andPP1D(differentiation, no integration by parts) matrices. Before #3, there was no support forDirichletBC()in 1D.This change makes sure that the
MM1DandPP1Dmatrices are only assembled with either a NaturalBC or a PeriodicBC. This is done through a function interfacefirst_derivative_boundary_condition()that returns a NaturalBC if a DirichletBC is stored in the FiniteElementCoordinate struct.