Skip to content

Fix azure fs #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tramora merged 2 commits into from
Jun 30, 2026
Merged

Fix azure fs #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffb0a4d
Remove a check in the Conda recipe to fix the build
Jun 25, 2026
5d0ac90
Fix wrong `FilesystemResource::create_parent` and ``AzureStorageResou…
Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions khiops/core/internals/filesystems.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ def create_child(self, file_name):
"""

@abstractmethod
def create_parent(self, file_name):
def create_parent(self):
"""Creates a resource representing the parent of this instance

Returns
Expand Down Expand Up @@ -812,7 +812,7 @@ def __init__(self, uri):
def create_child(self, file_name):
return create_resource(_child_uri_info(self.uri_info, file_name).geturl())

def create_parent(self, file_name): # pylint: disable=unused-argument
def create_parent(self):

@popescu-v popescu-v Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd opportunistically add an automated test, perhaps in tests/test_remote_access.py, that this method behaves as expected for all drivers.

@tramora tramora Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were changed to use a remote output_dir

return create_resource(_parent_uri_info(self.uri_info).geturl())

def _uri_parts(self):
Expand Down
3 changes: 1 addition & 2 deletions packaging/conda/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ requirements:
- setuptools
run:
- python >={{ python_min }}
- khiops-core =11.0.1rc2
- khiops-core =11.0.1rc.2
- pandas >=2.3.3,<4.0.0
- scikit-learn >=1.7.2,<1.9.0
run_constrained:
Expand All @@ -42,7 +42,6 @@ test:
imports:
- khiops
commands:
- pip check
- kh-status
- kh-samples --help
- kh-download-datasets --help
Expand Down
5 changes: 5 additions & 0 deletions tests/test_remote_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,10 +237,15 @@ def test_train_predictor_with_remote_access(self):
iris_data_dir = fs.get_child_path(kh.get_runner().samples_dir, "Iris")
# ask for folder cleaning during tearDown
self.folder_name_to_clean_in_teardown = output_dir = fs.get_child_path(
# TODO : use `kh.get_runner().root_temp_dir` instead as soon as
# https://github.com/KhiopsML/khiops-python/issues/593 is fixed
# so that `output_dir` becomes remote (except for Docker)
self.results_dir_root(),
f"test_{self.remote_access_test_case()}_remote_files_{uuid.uuid4()}",
)

# TODO : remove this block as soon as
# https://github.com/KhiopsML/khiops-python/issues/593 is fixed
# Attempt to make local directory if not existing
if not fs.exists(output_dir) and fs.is_local_resource(output_dir):
fs.make_dir(output_dir)
Expand Down
Loading