Fix azure fs#591
Merged
Merged
Conversation
popescu-v
reviewed
Jun 26, 2026
popescu-v
reviewed
Jun 26, 2026
| return create_resource(_child_uri_info(self.uri_info, file_name).geturl()) | ||
|
|
||
| def create_parent(self, file_name): # pylint: disable=unused-argument | ||
| def create_parent(self): |
Collaborator
There was a problem hiding this comment.
I'd opportunistically add an automated test, perhaps in tests/test_remote_access.py, that this method behaves as expected for all drivers.
Collaborator
Author
There was a problem hiding this comment.
The tests were changed to use a remote output_dir
popescu-v
requested changes
Jun 26, 2026
popescu-v
left a comment
popescu-v
left a comment
Collaborator
There was a problem hiding this comment.
Also add PR to the khiops-feedstock conda-forge repo for the Conda recipe
- disable the old 'pip check' in the `test.commands` to avoid a failure because the project dependencies are missing
Collaborator
Author
It was already done during the RC2 release. The current change in our dev Conda recipe was done to keep in sync with the feedstock feedstock. |
popescu-v
approved these changes
Jun 30, 2026
…rceMixin::create_parent` definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During manual tests against remote files a bad definition of a method raised an error.
TODO Before Asking for a Review
main(ormain-v10)Unreleasedsection ofCHANGELOG.md(no date)index.html