-
Notifications
You must be signed in to change notification settings - Fork 0
Unify cursors #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adivate2021
wants to merge
1
commit into
staging
Choose a base branch
from
aaryan/unify-cursors
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unify cursors #17
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Response cursor types for sessions/traces search not updated to match request migration
The
AgentThreadsListResponse.next_cursorwas updated from a structured type (AgentThreadsListResponseNextCursorOption1withupdated_at/thread_id) tostr | Noneatsrc/judgment_cli/generated/types.py:364, consistent with the request body change. However,SessionsSearchResponse.nextCursorat line 1862 still uses structuredSessionsSearchResponseNextcursorOption1(withsort_value/session_id), andTracesSearchResponse.nextCursorat line 2047 still uses structuredTracesSearchResponseNextcursorOption1(withsort_value/trace_id). Meanwhile, their request body pagination types (SessionsSearchBodyPagination.cursorat line 1902 andTracesSearchBodyPagination.cursorat line 2146) were both changed tostr | None. Since all these files are auto-generated from the OpenAPI spec, this asymmetry likely reflects the actual API state (perhaps sessions/traces endpoints still return structured cursors while accepting a string in the request). Worth confirming with the API team that the spec is accurate and the sessions/traces response cursor types don't need the same migration.(Refers to lines 1854-1862)
Was this helpful? React with 👍 or 👎 to provide feedback.