Unify cursors#17
Conversation
There was a problem hiding this comment.
🚩 Response cursor types for sessions/traces search not updated to match request migration
The AgentThreadsListResponse.next_cursor was updated from a structured type (AgentThreadsListResponseNextCursorOption1 with updated_at/thread_id) to str | None at src/judgment_cli/generated/types.py:364, consistent with the request body change. However, SessionsSearchResponse.nextCursor at line 1862 still uses structured SessionsSearchResponseNextcursorOption1 (with sort_value/session_id), and TracesSearchResponse.nextCursor at line 2047 still uses structured TracesSearchResponseNextcursorOption1 (with sort_value/trace_id). Meanwhile, their request body pagination types (SessionsSearchBodyPagination.cursor at line 1902 and TracesSearchBodyPagination.cursor at line 2146) were both changed to str | None. Since all these files are auto-generated from the OpenAPI spec, this asymmetry likely reflects the actual API state (perhaps sessions/traces endpoints still return structured cursors while accepting a string in the request). Worth confirming with the API team that the spec is accurate and the sessions/traces response cursor types don't need the same migration.
(Refers to lines 1854-1862)
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.