feat(web): guide Watch sharing by user intent - #2003
Open
lumberman wants to merge 8 commits into
Open
Conversation
Collaborator
Author
Residual Review Findings
Source: compound-engineering code-review run |
|
🚅 Deployed to the forge-pr-2003 environment in forge
6 services not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Watch sharing now starts with the user's goal instead of a flat list of tools. Each path shows only the relevant next step: link posts for social platforms, a Watch URL for messages, the existing download flow for offline use, iframe code for websites, and the approved licensing intake for native upload or clip reuse.
This resolves FGE-64 without inventing legal policy. Existing canonical URLs, iframe bytes, download ownership, Facebook/X links, clipboard behavior, and modal lifecycle remain intact.
Work Loop
ce:plandonece:workdonece:reviewdonece:compounddoneNotes
Review focus
Localization
All 43 new
ShareModalpaths exist in every catalog as explicit pending English fallback. Translation credentials were unavailable, so this PR does not claim translated or human-reviewed copy. The added English namespace payload is 1,011 bytes gzip.Page-loading evidence
The final production build matches the commit. The Share modal remains outside the root main bundle and loads through the existing lazy boundary.
Validation
git diff --checkpassed.design-qa.md.Related work
docs/plans/2026-08-21-2229-feat-watch-share-usage-guidance-plan.mddocs/roadmap/platform/feat-412-watch-share-usage-guidance.mddocs/solutions/design-patterns/watch-share-intent-capability-routing.mdSession-settled decisions carried from planning: preserve link and iframe behavior; route permission questions instead of authoring legal policy; and keep divergent residuals in durable trackers.