Fix CI build: allow dependency build scripts (pnpm v11 allowBuilds) - #181
Merged
Merged
Conversation
After the overrides fix, the release build fails at 'Install dependencies' with ERR_PNPM_IGNORED_BUILDS for @biomejs/biome, electron and esbuild. pnpm v10+ blocks dependency build scripts by default, and the CI installs pnpm@latest (v11), which requires an explicit allow-list via the allowBuilds map in pnpm-workspace.yaml (pnpm even writes a stub asking for it). Setting the three packages to true lets their postinstall scripts run. Verified: a clean 'CI=true pnpm install --frozen-lockfile' followed by 'pnpm run build' both exit 0; pnpm-lock.yaml is unchanged.
Flake Review Results for #181Available systems: aarch64-darwin, aarch64-linux, armv6l-linux, armv7l-linux, i686-linux, powerpc64le-linux, riscv64-linux, x86_64-darwin, x86_64-freebsd, x86_64-linux 🔄 Modified (2)
Generated by flake-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With #180 merged, the
[master] Releasebuild now gets past the overrides error and fails at the next step, Install dependencies:Cause
pnpm v10+ blocks dependency build scripts by default for security. The CI installs
pnpm@latest(currently v11) viapnpm/action-setup@v4, which requires an explicit allow-list. In pnpm v11 this is theallowBuildsmap inpnpm-workspace.yaml(pnpm even writes a stub promptingset this to true or falsefor each package). Without it, the install aborts with exit 1.Fix
Add
allowBuildstopnpm-workspace.yamlwith the three packages that ship postinstall scripts set totrue:Verification
On a clean checkout (empty
node_modules), mirroring CI:CI=true pnpm install --frozen-lockfile-> exit 0 (all three postinstalls run: electron, esbuild, biome)pnpm run build-> exit 0 (injector + luna.dev/lib/ui built)pnpm-lock.yamlis unchanged, so no relock is needed.