feat: add preparation space check step to fail fast - #122
Open
MRGuziX wants to merge 3 commits into
Open
Conversation
3 files modified:
1. ai4rag/utils/validators.py — added validate_model_list() function (moved from search_space_preparation.py)
2. ai4rag/components/optimization/search_space_preparation.py —
- Imports validate_model_list from shared location + AI4RAGSearchSpace
- Adds _validate_model_list = validate_model_list alias for backward compat
- Adds pre_validated_search_space: AI4RAGSearchSpace | None = None parameter to prepare_search_space_report()
- When provided: skips model validation, payload construction, and prepare_search_space_with_ogx() call
- When None: existing behavior unchanged
3. tests/unit/ai4rag/components/optimization/test_search_space_prep.py —
- Added TestValidateModelListShared (verifies alias identity)
- Added TestPrepareSearchSpaceReportPreValidated with 3 tests: skips OGX call, uses provided search space, still loads documents
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
MRGuziX
marked this pull request as ready for review
August 6, 2026 09:06
| return value | ||
|
|
||
|
|
||
| def validate_model_list(models: list[str] | None, name: str) -> None: |
Collaborator
There was a problem hiding this comment.
I am not sure if this is the right place for this function. Maybe, let's leave it in ai4rag/components/optimization/search_space_preparation.py
Collaborator
There was a problem hiding this comment.
@MRGuziX Could you address this comment? Thanks
3 tasks
| pre_validated_search_space | ||
| When provided, the function skips model-list validation, | ||
| payload construction, and the | ||
| :func:`prepare_search_space_with_ogx` call and uses this |
Collaborator
There was a problem hiding this comment.
Suggested change
| :func:`prepare_search_space_with_ogx` call and uses this | |
| `prepare_search_space_with_ogx` call and uses this |
The markup :func:prepare_search_space_with_ogx is Sphinx reStructuredText (rst) syntax. Let's use sth closer to google style.
Collaborator
|
@MRGuziX what about this PR? Is this valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should fail fast when it come to the checking of space_preparation step, right now user can launch experiment that will take hours, and after that we will show him info "yo, your model is wrong" he cannot re-trigger it with a changed config, he cannot do anything to save hours of computing. So we need to fail fast to give him info that his provided input is "ok" or "nook"
Motivation
https://redhat.atlassian.net/browse/RHOAIENG-57709
Changes
- Imports validate_model_list from shared location + AI4RAGSearchSpace
- Adds _validate_model_list = validate_model_list alias for backward compat
- Adds pre_validated_search_space: AI4RAGSearchSpace | None = None parameter to prepare_search_space_report()
- When provided: skips model validation, payload construction, and prepare_search_space_with_ogx() call
- When None: existing behavior unchanged
- Added TestValidateModelListShared (verifies alias identity)
- Added TestPrepareSearchSpaceReportPreValidated with 3 tests: skips OGX call, uses provided search space, still loads documents
Testing
Checklist