feat: add search space validation step for fail-fast on misconfiguration - #124
Merged
jakub-walaszczyk merged 6 commits intoAug 6, 2026
Merged
Conversation
3 files modified:
1. ai4rag/utils/validators.py — added validate_model_list() function (moved from search_space_preparation.py)
2. ai4rag/components/optimization/search_space_preparation.py —
- Imports validate_model_list from shared location + AI4RAGSearchSpace
- Adds _validate_model_list = validate_model_list alias for backward compat
- Adds pre_validated_search_space: AI4RAGSearchSpace | None = None parameter to prepare_search_space_report()
- When provided: skips model validation, payload construction, and prepare_search_space_with_ogx() call
- When None: existing behavior unchanged
3. tests/unit/ai4rag/components/optimization/test_search_space_prep.py —
- Added TestValidateModelListShared (verifies alias identity)
- Added TestPrepareSearchSpaceReportPreValidated with 3 tests: skips OGX call, uses provided search space, still loads documents
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Collaborator
Author
This will be addressed soon
|
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
Signed-off-by: Tomasz Guzik <tguzik@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_model_list()toai4rag/utils/validators.pyas a shared validation functionprepare_search_space_report()to accept optionalpre_validated_search_spaceparameter — when provided, skips redundant OGX validation callsBackport of #122 to
release/0.11.Test plan
test_search_space_prep.py)🤖 Generated with Claude Code