fix(video): validate pass-through fixed GOP cadence - #380
Open
victorwon2001 wants to merge 1 commit into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gop_secondsand each channel's measured frame rate before provenance is written.video-keyframe-cadencedoctor error while preserving existing malformed-payload and stream-start diagnostics.Fixes #376
Why
Pass-through episodes previously stamped
gop_secondsas the interval actually used without verifying that their H.264 keyframes followed that cadence. Refusing off-grid pass-through streams and checking existing files inhflow doctormakes that provenance assertion verifiable without changing the provenance schema or re-encode behavior.Validation
Focused and full test suites passed, and lint, formatting, type checking, documentation links, and diff whitespace checks are clean.
Checklist
uv run ruff check --fix,uv run ruff format, anduv run ty check.